Minor perf fixes for LazyItemEvaluator#6529
Merged
rainersigwald merged 1 commit intodotnet:mainfrom Jun 17, 2021
Merged
Conversation
ladipro
approved these changes
Jun 8, 2021
Member
ladipro
left a comment
There was a problem hiding this comment.
Have you measured how many allocated bytes it saves when evaluating a typical .NET Core project? Thank you!
Member
Author
|
Well, according to my measurements, the number of metadata items for OrchardCore is 454,671, and for each item we should save 8B, that would give us ~3,46MB. It was likely gen 0 allocations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6062
Context
Minor fixes for the LazyItemEvaluator: unnecessary memory allocations were removed.
Testing
Manual testing.