Msbuilddisablenodereuse live check#5764
Merged
rainersigwald merged 1 commit intodotnet:vs16.7from Oct 6, 2020
Merged
Conversation
benvillalobos
approved these changes
Oct 2, 2020
Fix https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1197992 by disabling the caching of the MSBUILDDISABLENODEREUSE environment-variable check and doing it live for every check.
504e1c7 to
55db00d
Compare
rainersigwald
approved these changes
Oct 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for AB#1197992.
Customer Impact
Customers can specify whether they want nodes to be reused after startup. A change in 16.7 cached it, breaking a VS extension.
Testing
No current testing, but the author can add a unit test.
Risk
Low. The code change is minimal and although customers could have started changing the value of the environment variable after startup since 16.7, there is no clear benefit to doing so.
Code Reviewers
Rainer, Ben
Description of fix
Disable caching of MSBUILDDISABLENODEREUSE variable.