Adopt Shouldly for test assertions #2250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
fyi the CLI repo makes heavy use of FluentAssertions and already built a set of very useful extensions for it, mostly around filesystem concerns (e.g. |
374303d to
e4c9d69
Compare
Contributor
Author
|
@dotnet-bot test Windows_NT Build for Full please |
Update Framework unit tests to use Shouldly [Shouldly](https://github.com/shouldly/shouldly) provides extension methods for assertions and also creates very detailed messages when assertions fail. The documentation is here: http://shouldly.readthedocs.io
…OnlyWhenDifferentTest Add some tolerance to the time checking Only check last write time
* Version 3.0.0 contains fix for signing issue in the previous version. * Remove NoWarn for unsigned reference (no longer needed)
Contributor
Author
|
@AndyGerlicher can I merge this now? |
AndyGerlicher
approved these changes
Jul 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Framework unit tests to use Shouldly
Shouldly provides extension methods for assertions and also creates very detailed messages when assertions fail. The documentation is here: http://shouldly.readthedocs.io