[vs18.5] always use Path.GetFullPath() in path canonicalization#13392
Merged
JanProvaznik merged 2 commits intodotnet:vs18.5from Mar 18, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adjusts path canonicalization behavior in AbsolutePath and bumps the repo version prefix for a servicing release.
Changes:
- Removes the pre-check/fast-path in
AbsolutePath.GetCanonicalForm(), making it always callPath.GetFullPath. - Updates
VersionPrefixfrom18.5.0to18.5.1ineng/Versions.props.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Framework/PathHelpers/AbsolutePath.cs | Simplifies canonicalization by always normalizing via Path.GetFullPath. |
| eng/Versions.props | Increments the product version prefix for the next servicing build. |
You can also share your feedback on Copilot code review. Take the survey.
AR-May
approved these changes
Mar 16, 2026
Member
Author
|
TBD Version bump after the other PR is merged. |
OvesN
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2828597