Revert "Migrate Exec task to TaskEnvironment API"#13367
Merged
rainersigwald merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
This reverts commit 074bba0.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the earlier change that migrated the Exec task to the TaskEnvironment API, restoring the prior execution model to address VMR rebootstrap failures (dotnet/dotnet#5385).
Changes:
- Reverts
Execto no longer be treated as a multi-threadable task and removes itsTaskEnvironmentintegration. - Restores
Execworking directory behavior to default to the process current directory whenWorkingDirectoryis not specified. - Removes the test helper and unit tests that specifically validated the reverted
TaskEnvironment-based behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/UnitTests.Shared/TaskEnvironmentHelper.cs |
Removes the multithreaded TaskEnvironment test helper that was only needed for the reverted behavior. |
src/Tasks/Exec.cs |
Drops TaskEnvironment usage and multithreadable markings; reverts working directory/env handling to the pre-migration approach. |
src/Tasks.UnitTests/Exec_Tests.cs |
Removes TaskEnvironment setup and deletes tests that targeted the reverted TaskEnvironment-specific semantics. |
You can also share your feedback on Copilot code review. Take the survey.
rainersigwald
approved these changes
Mar 11, 2026
AR-May
approved these changes
Mar 11, 2026
Member
|
Clean revert, most legs passed, queuing very badly on multithreaded and mac jobs, blocking VMR rebootstrap--I'm going to merge. |
This was referenced Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #13171
breaks VMR rebootstrap
dotnet/dotnet#5385
problem 1:
direct instantation of Exec without task environment
problem 2:
task inheriting from Exec pushed to taskhost