Skip to content

Update VersionPrefix to 18.6.0 + insertion flow#13296

Merged
MichalPavlik merged 5 commits intomainfrom
dev/mipavlik/bump_to_vs_18.6
Feb 26, 2026
Merged

Update VersionPrefix to 18.6.0 + insertion flow#13296
MichalPavlik merged 5 commits intomainfrom
dev/mipavlik/bump_to_vs_18.6

Conversation

@MichalPavlik
Copy link
Copy Markdown
Member

Update VersionPrefix to 18.6.0 + insertion flow

@MichalPavlik MichalPavlik requested a review from a team as a code owner February 26, 2026 12:48
Copilot AI review requested due to automatic review settings February 26, 2026 12:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates MSBuild versioning to align with the next release train (18.6) and adjusts VS insertion/merge-flow configuration to account for new/updated servicing branches.

Changes:

  • Bump VersionPrefix to 18.6.0 and advance the package validation baseline to 18.5.0.
  • Add rel/d18.6 as a VS insertion target and update auto-targeting logic for vs18.6.
  • Update merge-flow configuration to insert a vs18.5 hop before merging to main.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
eng/Versions.props Version bump to 18.6.0 and baseline update for package validation.
azure-pipelines/vs-insertion.yml Adds 18.6 insertion target and updates auto branch mapping logic.
azure-pipelines/vs-insertion-experimental.yml Adds 18.6 insertion target for experimental insertions and removes an older target.
.config/git-merge-flow-config.jsonc Adjusts the servicing merge chain (notably around 18.4/18.5).
Comments suppressed due to low confidence (3)

.config/git-merge-flow-config.jsonc:12

  • The merge-flow chain now routes vs16.11 to vs17.8, but there is no configuration entry for vs17.8. This breaks the stated “servicing chain … through … to main” because automation will stop at vs17.8. Add a vs17.8 entry (e.g., to vs17.10 or whatever the next branch should be) or change vs16.11 to merge directly into the next configured branch.
        // Automate opening PRs to merge msbuild's vs16.11 (VS until 4/2029) into vs17.8 (SDK 8.0.1xx)
        "vs16.11": {
            "MergeToBranch": "vs17.8"
        },
        // Automate opening PRs to merge msbuild's vs17.10 (SDK 8.0.3xx) into vs17.11 (SDK 8.0.4xx)
        "vs17.10": {
            "MergeToBranch": "vs17.11"
        },

.config/git-merge-flow-config.jsonc:40

  • With the repository moving forward (VersionPrefix 18.6.0 and insertion targeting rel/d18.6), the merge-flow config likely needs to be extended to include the new vs18.6 step (e.g., vs18.5 -> vs18.6 and vs18.6 -> main). As-is, automation will skip vs18.6 entirely and continue merging vs18.5 directly to main.
        // Automate opening PRs to merge msbuild's vs18.4 (VS) into vs18.5 (VS)
        "vs18.4": {
            "MergeToBranch": "vs18.5"
        },
        // Automate opening PRs to merge msbuild's vs18.5 (VS) into main (VS canary, SDK main & next-feature-band)
        "vs18.5": {
            "MergeToBranch": "main"
        }

azure-pipelines/vs-insertion.yml:48

  • The TargetBranch values entry for rel/d18.6 has trailing whitespace. This can cause noisy diffs and may break strict YAML linting; please remove the extra spaces.
      - main
      - rel/d18.6  
      - rel/d18.5

Copy link
Copy Markdown
Member

@JanProvaznik JanProvaznik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question about versions

Co-authored-by: Rainer Sigwald <raines@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants