[vs18.3] Set DotNetFinalVersionKind to release#13066
Merged
ViktorHofer merged 3 commits intovs18.3from Jan 20, 2026
Merged
Conversation
d15d28c to
d1f3f82
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements packet version negotiation for communication between MSBuild nodes, removes OpenTelemetry dependencies in favor of a simpler telemetry approach, refactors command-line parsing, and makes various infrastructure improvements for Visual Studio 18.3 compatibility.
Changes:
- Implements packet version negotiation protocol (v1→v2) for parent-child node communication with HostServices and target name support
- Removes OpenTelemetry dependencies and replaces with Visual Studio Telemetry on .NET Framework and ActivitySource on .NET
- Refactors command-line parsing into a separate
CommandLineParserclass and addsMSBUILD_LOGGING_ARGSenvironment variable support - Removes conditional compilation guards for
System.Diagnostics.CodeAnalysis(now available on all platforms) - Adds
[MSBuildMultiThreadableTask]attribute to several task classes
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| template_feed/.../template.json | Version bump from 18.3.0 to 18.4.0 |
| src/Tasks/*.cs | Removed #if NET guards for CodeAnalysis and added multithreading attributes |
| src/Shared/TaskHostConfiguration.cs | Added packet version negotiation, HostServices, target/project name fields |
| src/Shared/INodePacket.cs | Incremented packet version to 2, added version negotiation method |
| src/Shared/CommunicationsUtilities.cs | Implemented packet version exchange in handshake protocol |
| src/Shared/NodeEndpointOutOfProcBase.cs | Added parent packet version tracking |
| src/MSBuild/XMake.cs | Massive refactoring - extracted command-line parsing, simplified Main, updated telemetry |
| src/MSBuild/CommandLine/*.cs | New command-line parser infrastructure with environment variable support |
| src/MSBuild/OutOfProc*.cs | Added parent packet version and HostServices support |
| src/Framework/Telemetry/*.cs | Complete telemetry refactoring - removed OpenTelemetry, added VS Telemetry wrapper |
| src/Framework/Traits.cs | Added MSBUILD_LOGGING_ARGS support, removed telemetry sample rate |
| Package files | Removed OpenTelemetry and related dependencies |
| Test files | Updated for new APIs and added new test coverage |
rainersigwald
approved these changes
Jan 20, 2026
This was referenced Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.