Fix dependabot global.json scanning and clean-up#12898
Merged
ViktorHofer merged 7 commits intomainfrom Dec 9, 2025
Merged
Conversation
Add an empty global.json to eng/dependabot so that it never scans the one in the repo root and then attempts to load and update the msbuild sdks defined there. Also rename Packages.props to Directory.Packages.props and delete the unnecessary dependabot.csproj as dependabot now has native support for D.P.props.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Dependabot configuration by preventing it from scanning the root global.json file (which contains MSBuild SDK definitions that shouldn't be auto-updated) and modernizes package management by renaming Packages.props to the standard Directory.Packages.props filename. It also removes obsolete ProjectIsDeprecated conditions that referenced a property no longer in use.
- Adds an empty
global.jsontoeng/dependabot/to prevent Dependabot from scanning the root global.json'smsbuild-sdkssection - Renames
eng/dependabot/Packages.propstoDirectory.Packages.propsand deletes the workarounddependabot.csproj(Dependabot now has native support for Directory.Packages.props) - Removes all
ProjectIsDeprecatedconditions as this property is no longer used in the codebase
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| eng/dependabot/global.json | New empty JSON file that prevents Dependabot from scanning the root global.json containing msbuild-sdks |
| eng/dependabot/dependabot.csproj | Deleted workaround file no longer needed since Dependabot has native Directory.Packages.props support |
| eng/dependabot/Directory.Packages.props | Renamed from Packages.props; removed obsolete $(ProjectIsDeprecated) condition from GlobalPackageReference ItemGroup |
| eng/Versions.props | Updated comment to reference new filename Directory.Packages.props |
| eng/Directory.Packages.props | Updated Import path and comment to reference new filename Directory.Packages.props |
| Directory.Build.props | Updated DirectoryPackagesPropsPath property to point to the renamed file |
| Directory.Build.targets | Removed obsolete $(ProjectIsDeprecated) condition from Global Analyzer Config ItemGroup |
Comments suppressed due to low confidence (1)
eng/dependabot/Directory.Packages.props:4
- The comment still references the old filename
Packages.propsinstead ofDirectory.Packages.props. This should be updated to:Versions managed by Darc/Maestro should be in ..\Directory.Packages.props.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Removed comment for including Common.globalconfig.
YuliiaKovalova
approved these changes
Dec 9, 2025
This was referenced Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops PR like #12888 getting opened
Add an empty global.json to eng/dependabot so that it never scans the one in the repo root and then attempts to load and update the msbuild sdks defined there.
Also rename Packages.props to Directory.Packages.props and delete the unnecessary dependabot.csproj as dependabot now has native support for D.P.props.
Unrelated but in the same files: Also remove
ProjectIsDeprecatedconditions as that property is already dead.