Add opt-in for default channel registrations check#12028
Merged
JanProvaznik merged 2 commits intomainfrom Jun 18, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds an opt-in flag to enforce default-channel registrations in the .NET YAML pipeline, making validation errors more explicit.
- Introduces
requireDefaultChannels: trueunder source validation settings. - Improves error output clarity when default channels are missing.
Comments suppressed due to low confidence (2)
.vsts-dotnet.yml:331
- [nitpick] Include a comment or update the pipeline documentation to explain what
requireDefaultChannelsdoes and when to enable it, so maintainers understand its impact.
requireDefaultChannels: true
.vsts-dotnet.yml:331
- Add or update pipeline tests to cover scenarios with
requireDefaultChannelsenabled, ensuring the default-channel enforcement behaves as expected.
requireDefaultChannels: true
JanProvaznik
approved these changes
Jun 18, 2025
rainersigwald
approved these changes
Jun 18, 2025
Member
rainersigwald
left a comment
There was a problem hiding this comment.
Let's see how this goes. I'm glad there's an escape hatch for advanced scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add opt-in for default channel registrations check
Fixes #11214
The error output is more explicit after the change
