Support for building on ubuntu 16.04#1194
Conversation
* Detect the runtime in cibuild.sh * Pass that along to our runtime dependencies instead of it being hard coded to ubuntu 14 Closes dotnet#833
| fi | ||
| } | ||
|
|
||
| get_current_linux_name() { |
There was a problem hiding this comment.
Comment where this mess comes from (at a bare minimum in the commit notes).
|
|
||
| Linux) | ||
| OS_ARG="Unix" | ||
| EXTRA_ARGS="$EXTRA_ARGS /p:RuntimeSystem=$(get_current_linux_name)" |
There was a problem hiding this comment.
You can call a function like this? Huh! bash_skillz++
There was a problem hiding this comment.
I just copied it from init-tools.sh, I take no credit whatsoever.
| "ubuntu.14.04-x64": {} | ||
| "ubuntu.14.04-x64": {}, | ||
| "ubuntu.16.04-x64": {}, | ||
| "ubuntu.16.10-x64": {} |
There was a problem hiding this comment.
Do we support 16.10? I thought we were just going for LTS releases, but I see 16.10 on corefx, too.
There was a problem hiding this comment.
16.10 is in the build tools project.json so I figured I'd add it here. I technically tested this on 16.04. Should I not include 16.10?
There was a problem hiding this comment.
Go ahead and leave it in. We just won't advertise it :)
dir.props
Outdated
| <!-- Possible Values: win7 / ubuntu14.04 / osx.10.10 --> | ||
| <RuntimeSystem Condition="'$(TargetPlatformIdentifier)' == 'Windows_NT'">win7</RuntimeSystem> | ||
| <RuntimeSystem Condition="'$(TargetPlatformIdentifier)' == 'Unix'">ubuntu.14.04</RuntimeSystem> | ||
| <RuntimeSystem Condition="'$(RuntimeSystem)' == '' and '$(TargetPlatformIdentifier)' == 'Unix'">ubuntu.14.04</RuntimeSystem> |
There was a problem hiding this comment.
So . . . technically this check isn't required, because the externally-specified global property will prevent this assignment from having any effect. Thoughts on relying on that versus leaving this change in?
There was a problem hiding this comment.
Yeah I originally was scared of removing it because I didn't want to break anything else but after I searched more I can see it's not used anywhere else. I'll remove it.
Also upgrade a few packages to released versions
Closes #833