Merged
Conversation
JanProvaznik
approved these changes
Feb 21, 2025
AR-May
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1980399/
Context
MSBuild has custom xml parsing logic that is trying to distinguish whether the element content should be treated as regular xml element content (
XmlNode.InnerText) or whether we want to allow users to pass in the actual unescaped xml (XmlNode.InnerXml)The second option feels as not very good choice (allowing to specify xml recognized sequences within xml script, without properly escaping them) - but since it is already preexisting behavior, let's keep it.
The recgnition of CData section was inefficient and defective - not allowing leading whitespaces - so I've fixed at least that one
Changes Made
CData recognition now skips the leading whitespaces.
Testing
Manual testing - loaded the repro project from the case into VS with and without fix and verified this is fixing the issue