Removing last instances of the BinaryFormatter#11346
Merged
JanProvaznik merged 6 commits intomainfrom Feb 12, 2025
Merged
Conversation
JanKrivanek
approved these changes
Jan 28, 2025
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
Looks good.
I'd just suggest to keep this warning on NETFx
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
Member
|
to fix the build issue you need to build msbuild locally and have the strings generated again. |
Member
Author
Yeah, it's not the first time I've encountered this kind of error, but thank you :) |
YuliiaKovalova
approved these changes
Jan 29, 2025
rainersigwald
approved these changes
Jan 29, 2025
Member
rainersigwald
left a comment
There was a problem hiding this comment.
LGTM! For this kind of change I would find it quite helpful to see screenshots/console transcripts of the "after" experience with the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11323
Context
We used
BinaryFormatterin the serialization logic to support build custom events. With the VS 17.14, we can remove the last instances of theBinaryFormatterin our codebase.Changes Made
TranslateDotNetimplementation was removed andOutOfProcNodenow unconditionally emits build error instead of sending packets with the custom event.Testing
Modified existing unit test.
Notes