Harden the ID-to-project file map misses#11289
Merged
JanKrivanek merged 1 commit intomainfrom Jan 22, 2025
Merged
Conversation
SimaTian
approved these changes
Jan 20, 2025
YuliiaKovalova
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11095
Context
AssemblyLoadBuildEventArgs are logged asynchronously, and build doesn't wait for those, so it can happen that ProjectFinishedEventArgs occurred first - removing the id->file mapping from the map, but AssemblyLoadsTracker still uses the BuildEventContext for that project.
This would previously lead to a build crash. Since this is very benign scenario - let's add a grace handle for it.