Implement OpenTelemetry infrastructure#11255
Merged
JanProvaznik merged 66 commits intodotnet:mainfrom Feb 21, 2025
Merged
Conversation
7c1bae8 to
49467bb
Compare
62af4f0 to
cdaa52a
Compare
JanKrivanek
reviewed
Jan 13, 2025
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
Looks great!
I'm not yet reay to sign off - I need a second detailed look, plus there are some notes I put where I'd want your answers first.
YuliiaKovalova
approved these changes
Jan 15, 2025
JanKrivanek
approved these changes
Feb 2, 2025
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
Looks great!!!
I added couple smaller things for consideration - but none are really blocking
… early return in initialize, exception pattern match
This was referenced Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10945 #10948
Context
#10560
Changes Made
add singleton OpenTelemetryManager
executions in Framework (standalone and managed) trace and collect basic build events with a defined sampling rate.
Sending end of build telemetry comparable to the one sent in sdk.
Testing
Unit tests of the behavior,
monitoring if we get data to the backend
manual tests in experimental insertions
Notes