Fix setting package versions in VS insertion #11094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuliiaKovalova
approved these changes
Dec 6, 2024
Member
Author
|
/backport to vs17.12 |
Contributor
|
Started backporting to vs17.12: https://github.com/dotnet/msbuild/actions/runs/12198365503 |
Member
Author
|
/backport to vs17.11 |
Contributor
|
Started backporting to vs17.11: https://github.com/dotnet/msbuild/actions/runs/12198377051 |
Member
Author
|
/backport to vs17.8 |
Contributor
|
Started backporting to vs17.8: https://github.com/dotnet/msbuild/actions/runs/12198379379 |
Member
Author
|
vs17.10 was not merged so let's put it in the PR directly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11092
Context
a "refactor" in prior VS insertion pipeline PR introduced a bug where package properties would be set to empty string resulting in no update of them in VS PR
Changes Made
fix setting properties in the embedded PowerShell
Testing
(internal) https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/596781?_a=files
(internal) https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10665100&view=results
Notes
to be backported to vs17.8,10,11,12