Skip to content

[main] Update dependencies from dotnet/roslyn#10994

Merged
surayya-MS merged 4 commits intomainfrom
darc-main-1979a2c0-45df-4726-b1b1-94184dea4534
Nov 20, 2024
Merged

[main] Update dependencies from dotnet/roslyn#10994
surayya-MS merged 4 commits intomainfrom
darc-main-1979a2c0-45df-4726-b1b1-94184dea4534

Conversation

@dotnet-maestro
Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: 8a4332aa-2543-4c51-b941-e73f31e22328
  • Build: 20241117.1
  • Date Produced: November 18, 2024 5:58:07 AM UTC
  • Commit: 0a1a7c67471a1c6c521bd5258a2b6601a19722dd
  • Branch: refs/heads/main

…117.1

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.Net.Compilers.Toolset
 From Version 4.13.0-2.24561.1 -> To Version 4.13.0-2.24567.1
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner November 18, 2024 15:02
@surayya-MS surayya-MS enabled auto-merge (squash) November 19, 2024 09:13
@YuliiaKovalova
Copy link
Copy Markdown
Member

it looks like it wants this pr #10997 (review)

@GangWang01 GangWang01 requested a review from a team November 20, 2024 09:34
@GangWang01
Copy link
Copy Markdown
Member

@dotnet/source-build https://github.com/dotnet/msbuild/runs/33208091244 detected Microsoft.Net.Compilers.Toolset.4.13.0-2.24561.1 was be a new pre-built by this PR update. So add it to the exception list. Please help to review.

@surayya-MS surayya-MS merged commit dd52710 into main Nov 20, 2024
@surayya-MS surayya-MS deleted the darc-main-1979a2c0-45df-4726-b1b1-94184dea4534 branch November 20, 2024 09:56
@surayya-MS
Copy link
Copy Markdown
Member

The automatic merge was enabled, and the PR has merged. But we still need @dotnet/source-build review
Reverting this change

@ellahathaway
Copy link
Copy Markdown
Member

ellahathaway commented Nov 20, 2024

The automatic merge was enabled, and the PR has merged. But we still need @dotnet/source-build review Reverting this change

Sorry I missed this ping earlier.

It looks like the prebuilt version is being defined here:

<MicrosoftNetCompilersToolsetVersion>4.13.0-2.24561.1</MicrosoftNetCompilersToolsetVersion>
. I think updating it to the correct version will fix the issue. It looks like the change to the prop accidentally got reversed with this commit.

@surayya-MS
Copy link
Copy Markdown
Member

Thank you @ellahathaway !

@surayya-MS
Copy link
Copy Markdown
Member

Previously I reverted this change in #11006
No need to re-apply it because of the next update dependencies PR from dotnet/roslyn #11035

@surayya-MS surayya-MS self-assigned this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants