Merged
Conversation
JanKrivanek
reviewed
Aug 8, 2024
src/Build/BuildCheck/Infrastructure/BuildCheckBuildEventHandler.cs
Outdated
Show resolved
Hide resolved
MichalPavlik
reviewed
Aug 8, 2024
src/Build/BuildCheck/Infrastructure/BuildCheckBuildEventHandler.cs
Outdated
Show resolved
Hide resolved
AR-May
reviewed
Aug 8, 2024
src/Build/BuildCheck/Infrastructure/BuildCheckBuildEventHandler.cs
Outdated
Show resolved
Hide resolved
src/Build/BuildCheck/Infrastructure/BuildCheckBuildEventHandler.cs
Outdated
Show resolved
Hide resolved
AR-May
approved these changes
Aug 8, 2024
src/Build/BuildCheck/Infrastructure/BuildCheckBuildEventHandler.cs
Outdated
Show resolved
Hide resolved
src/Build/BuildCheck/Infrastructure/BuildCheckBuildEventHandler.cs
Outdated
Show resolved
Hide resolved
JanKrivanek
approved these changes
Aug 8, 2024
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
Looks good - let's please add few more improvements based on comments
src/Build/BuildCheck/Infrastructure/BuildCheckBuildEventHandler.cs
Outdated
Show resolved
Hide resolved
src/Build/BuildCheck/Infrastructure/BuildCheckBuildEventHandler.cs
Outdated
Show resolved
Hide resolved
Member
|
(Disabling automerge - let's merge after renaming merged) |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9747
Context
We don't want BuildCheck to run on restore, so we are skipping that.
Changes Made
Checked if we are restoring on the
RequestBuilder, as it is the place where we call BuildCheckManager directly to run the checks. And added extra handling to the BuildChecks logs for theBuildSubmissionStartedEventArgs, to account for out-of-proc processing of analyzers. When we get the event, it checks if it is running during the restore. If it is, all events handling is disabled until anotherBuildSubmissionStartedEventArgsto signal that the restore phase has ended.Testing
Added a test to run restore target without the build and check if there are BuildCheck outputs on it.