fix out of proc buildCheck invocation#10496
Merged
YuliiaKovalova merged 4 commits intodotnet:mainfrom Aug 8, 2024
Merged
Conversation
maridematte
approved these changes
Aug 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10176
Context
When BuildCheck was run in scope of out of pross execution, using BuildContext form the event was causing error
"ContextID {0} should have been in the ID-to-project file mapping but wasn't!".Changes Made
Jan's assumption was correct here:
#10176 (comment)
LoggingService on the receiving side doesn't have
_projectFileMappopulated, so on the attempt to read from it, exception was thrown.On existing customization in
ProjectStartedEventArgshandling we already have ContextID and ProjectFile to fill_projectFileMapif it's out of proc environment. When a BuildCheck event pops up, it's gracefully handled .Testing
The existing test was covering this gap
msbuild/src/BuildCheck.UnitTests/EndToEndTests.cs
Line 40 in 6bc91d5
Once I removed workaround bff8a4e, it failed.