Update configuration parsing logic#10361
Merged
f-alizada merged 8 commits intodotnet:mainfrom Jul 24, 2024
Merged
Conversation
f-alizada
commented
Jul 12, 2024
JanKrivanek
approved these changes
Jul 19, 2024
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
LGTM.
I'd maybe prefer BCL parsing where possible, but it's not a blocker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10232, Fixes: #10315
Context
Current implementation of the configuration closely connected to the naming of the Enum and its values.
For instance, in order to configure the EvaluationAnalysisScope of the BuilcCheck with the behavior ProjectOnly the
.editorconfigfile will look like that:which makes it impossible to set the configuration name and values different from the classes names, hence complicates the configuration time from user perspective.
Changes Made
many to 1mapping between the editorconfig and the value if needed:Testing