Add BuildCheck rule about used env variable#10307
Merged
YuliiaKovalova merged 35 commits intodotnet:mainfrom Jul 16, 2024
Merged
Add BuildCheck rule about used env variable#10307YuliiaKovalova merged 35 commits intodotnet:mainfrom
YuliiaKovalova merged 35 commits intodotnet:mainfrom
Conversation
…uliiaKovalova/msbuild into dev/ykovalova/used_envVariable
YuliiaKovalova
commented
Jul 11, 2024
…uliiaKovalova/msbuild into dev/ykovalova/used_envVariable
JanKrivanek
reviewed
Jul 12, 2024
Member
Author
|
experimental branch for perf check: https://github.com/dotnet/msbuild/tree/exp/ykovalova/extended_IProperty_check |
JanKrivanek
approved these changes
Jul 12, 2024
src/Build/BuildCheck/Analyzers/NoEnvironmentVariablePropertyAnalyzer.cs
Outdated
Show resolved
Hide resolved
f-alizada
reviewed
Jul 15, 2024
src/BuildCheck.UnitTests/TestAssets/SampleAnalyzerIntegrationTest/.editorconfig
Show resolved
Hide resolved
…uliiaKovalova/msbuild into dev/ykovalova/used_envVariable
f-alizada
approved these changes
Jul 16, 2024
Contributor
f-alizada
left a comment
There was a problem hiding this comment.
Leaving some comments to learn more about the introduced changes and educate myself with answers :)
src/Build/BuildCheck/Analyzers/NoEnvironmentVariablePropertyAnalyzer.cs
Outdated
Show resolved
Hide resolved
f-alizada
reviewed
Jul 16, 2024
This was referenced Jul 16, 2024
This was referenced Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9885
Context
The used environment variable will be reported after enabling this rule with pointing to exact file/location where it happened.
Changes Made
The logic for tracking location was added by extending interface IProperty with property location(file,column,line) . It can be reused for other rules too.
The created rule relies on the EnvironmentVariableRead event raise.
Testing
Extended existing e2e tests + REENABLED THEM