Wire up the properties reading/writing via loggingContexts#10237
Merged
JanKrivanek merged 29 commits intomainfrom Jul 25, 2024
Merged
Wire up the properties reading/writing via loggingContexts#10237JanKrivanek merged 29 commits intomainfrom
JanKrivanek merged 29 commits intomainfrom
Conversation
5 tasks
f-alizada
reviewed
Jul 2, 2024
src/Build/BuildCheck/Infrastructure/IBuildCheckManagerProvider.cs
Outdated
Show resolved
Hide resolved
Contributor
|
I'll need to do another round, over the changes. Thank you! |
Member
Author
|
Btw. there are heavy conflicts with current main - so I'm currently going through a bit of refactoring |
changed namespace to Microsoft.Build.Experimental.BuildCheck.Infrastructure for new interfaces
This reverts commit 8dbd500.
surayya-MS
approved these changes
Jul 4, 2024
Member
surayya-MS
left a comment
There was a problem hiding this comment.
Looks good to me!
When we create the analyzer, we should add to the doc that it won't work for replay mode
src/Build/BuildCheck/Infrastructure/IBuildEngineDataConsumer.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
Exp VS insertion: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/562854 |
AR-May
reviewed
Jul 8, 2024
src/Build/BuildCheck/Infrastructure/IBuildEngineDataConsumer.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: AR-May <67507805+AR-May@users.noreply.github.com>
…om/dotnet/msbuild into proto/buildcheck-properties-wiring
AR-May
approved these changes
Jul 8, 2024
Member
AR-May
left a comment
There was a problem hiding this comment.
Overall, this PR looks good for me.
src/Build/BuildCheck/Infrastructure/AnalysisContext/AnalysisLoggingContext.cs
Outdated
Show resolved
Hide resolved
src/Build/BuildCheck/Infrastructure/BuildCheckBuildEventHandler.cs
Outdated
Show resolved
Hide resolved
src/Build/BuildCheck/Infrastructure/BuildCheckManagerProvider.cs
Outdated
Show resolved
Hide resolved
src/Build/BuildCheck/Infrastructure/BuildCheckManagerProvider.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes towards #9883
Context
This is 2nd from sequence of 3 changesets delivering the "Undefined Property Used" BuildCheck
This changeset wires the property read and write info to the buildcheck. The data are being sent via the
LoggingContext->LoggingService->BuildCheckchain - so that we can easily add a reroute that will performLoggingContext->LoggingService->BuildEventArgs remoting to the central node->BuildCheckThe actuall check is not part of this changeset - it'll be delivered subsequently
Changes Made
BuildEventContextis allways initialized inLoggingServiceDesign documentation
(part of this PR)
https://github.com/dotnet/msbuild/blob/proto/buildcheck-properties-wiring/documentation/specs/proposed/BuildCheck-Architecture.md#sourcing-unexposed-data-from-within-execution
Notes