Add infra config to ConfigurationContext#10199
Merged
maridematte merged 10 commits intodotnet:mainfrom Jul 23, 2024
Merged
Conversation
f-alizada
approved these changes
Jun 4, 2024
Member
|
This looks great and meets original requirements. As discussed offline - let's change CustomConfigurationData so that it has RuleId, dictionary of custom key-values, BuildAnalyzerConfiguration - that way the accessing of custome or infra config would be same (by index, or searched by RuleId) |
f-alizada
approved these changes
Jun 27, 2024
JanKrivanek
reviewed
Jul 1, 2024
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
This looks good per the bug requirement. Though the real usage scenario (buildcheck needs to know whether a rule is enabled and what scope it should check) needs a bit of adjustment. Appology for original unclarity (I realized only after seeing the changes) - if it's easier, feel free to fix the comments here, push it, and solve effective config in separate PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10123
Changes Made
Analyzers now have access to infrastructure configuration data, which contains
severityandisEnabledattributes.