[BuildCheck] Implement double writes analyzer#10184
Merged
ladipro merged 9 commits intodotnet:mainfrom Jun 10, 2024
Merged
Conversation
9b8cf13 to
bd77da3
Compare
JanKrivanek
reviewed
May 31, 2024
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
Thank you!
I did just a first quick pass - but overall looks good.
I'll do more in depth review early next week
JanKrivanek
requested changes
Jun 4, 2024
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
Thank you! Looks very good!
The only reason I'm requesting changes is the rooting of the path in the AnalyzeWrite.
ladipro
commented
Jun 5, 2024
JanKrivanek
approved these changes
Jun 5, 2024
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
Thank you! Awesome work!!!
YuliiaKovalova
approved these changes
Jun 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9881
Context
We believe there is value in flagging cases where the same file is written by more than one task during a build. dotnet/source-build#4390 is an example of a recent hard-to-diagnose build issue that could have been prevented by this analyzer.
Changes Made
This PR adds a new built-in analyzer and makes a few supporting changes.
Testing
Notes
The changes contain a fix/workaround for #10176.