Skip to content

Update BuildCheck docs with enablement design#10033

Merged
ladipro merged 4 commits intodotnet:mainfrom
ladipro:analyzer-enablement
May 9, 2024
Merged

Update BuildCheck docs with enablement design#10033
ladipro merged 4 commits intodotnet:mainfrom
ladipro:analyzer-enablement

Conversation

@ladipro
Copy link
Copy Markdown
Member

@ladipro ladipro commented Apr 18, 2024

Fixes #9822
Fixes #9723

Context

Some of the built-in BuildCheck analyzers will eventually be enabled by default. We need to figure out the mechanics of how it's going to happen.

Changes Made

Updated parts of the BuildCheck spec documents.

Copy link
Copy Markdown
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the proposal!

I'm bit worried about flipping from switch to a property and hence possibility of that warying throughout the build.

Copy link
Copy Markdown
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is putting together lot of importnat thoughts - Thank you!!

@YuliiaKovalova YuliiaKovalova self-requested a review May 6, 2024 12:46
@rainersigwald rainersigwald requested a review from baronfel May 6, 2024 16:35
@ladipro ladipro enabled auto-merge (squash) May 9, 2024 21:02
@ladipro ladipro merged commit a8e224f into dotnet:main May 9, 2024
@ladipro ladipro deleted the analyzer-enablement branch May 10, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it possible to specify default enablement and severity of Rules (based on SdkAnalysisLevel) Analyzers prototyping - Opting in/out

5 participants