Instrumentation module for BuildCheck#10016
Merged
maridematte merged 23 commits intodotnet:mainfrom May 2, 2024
Merged
Conversation
JanKrivanek
requested changes
Apr 17, 2024
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
Overall looks good.
Please have a look on the merge leftovers. And add logging final merged stats as structured event to binlog
src/Build/BuildCheck/Infrastructure/BuildCheckConnectorLogger.cs
Outdated
Show resolved
Hide resolved
src/Build/BuildCheck/Infrastructure/BuildCheckManagerProvider.cs
Outdated
Show resolved
Hide resolved
JanKrivanek
requested changes
Apr 23, 2024
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
Overall looks good!
I have couple comments for consideration.
Please review the merge outcome - that your PR contains what it should
src/Build/BuildCheck/Infrastructure/BuildCheckConnectorLogger.cs
Outdated
Show resolved
Hide resolved
src/Build/BuildCheck/Infrastructure/BuildCheckManagerProvider.cs
Outdated
Show resolved
Hide resolved
src/Build/BuildCheck/Infrastructure/BuildCheckManagerProvider.cs
Outdated
Show resolved
Hide resolved
src/Build/BuildCheck/Infrastructure/BuildCheckManagerProvider.cs
Outdated
Show resolved
Hide resolved
f-alizada
approved these changes
Apr 29, 2024
JanKrivanek
approved these changes
Apr 29, 2024
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
Looks good!
I have couple commens for consideration
src/Build/BuildCheck/Infrastructure/BuildCheckConnectorLogger.cs
Outdated
Show resolved
Hide resolved
src/Build/BuildCheck/Infrastructure/BuildCheckManagerProvider.cs
Outdated
Show resolved
Hide resolved
src/Build/BuildCheck/Infrastructure/BuildCheckManagerProvider.cs
Outdated
Show resolved
Hide resolved
rainersigwald
approved these changes
Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9629
Context
We need some timers and performance indicators for BuildCheck.
Added
--analyzeStatsoption so it will report the time the BuildCheck infrastructure and individual analyzers performed to the command line, otherwise this information is just passed to the logger.Added timer to a few infrastructure points so we can know how they perform.
Preview of what the command line output looks like:
Re-making the PR from #9890.