I'd expect this to embed C:\temp\1.txt into the binlog, but it doesn't:
<Project>
<Target Name="Build">
<MSBuild Projects="$(MSBuildThisFileFullPath)" Targets="GetItems">
<Output TaskParameter="TargetOutputs" ItemName="EmbedInBinlog" />
</MSBuild>
</Target>
<Target Name="GetItems" Returns="@(ResultItem)">
<ItemGroup>
<ResultItem Include="C:\temp\1.txt" />
</ItemGroup>
</Target>
</Project>
As a workaround to fix this, also need to add an explicit ItemGroup:
<Project>
<Target Name="Build">
<MSBuild Projects="$(MSBuildThisFileFullPath)" Targets="GetItems">
<Output TaskParameter="TargetOutputs" ItemName="EmbedInBinlog" />
</MSBuild>
<ItemGroup>
<EmbedInBinlog Include="@(EmbedInBinlog)" />
</ItemGroup>
</Target>
<Target Name="GetItems" Returns="@(ResultItem)">
<ItemGroup>
<ResultItem Include="C:\temp\1.txt" />
</ItemGroup>
</Target>
</Project>
I think this line:
|
if (e.Kind == TaskParameterMessageKind.AddItem) |
should also allow for TaskParameterMessageKind.TaskOutput
I'd expect this to embed
C:\temp\1.txtinto the binlog, but it doesn't:As a workaround to fix this, also need to add an explicit ItemGroup:
I think this line:
msbuild/src/Build/Logging/BinaryLogger/BuildEventArgsWriter.cs
Line 521 in f1dae6a
should also allow for
TaskParameterMessageKind.TaskOutput