Fix flaky test TestTerminalLoggerTogetherWithOtherLoggers (#13044) ### Context Test `TestTerminalLoggerTogetherWithOtherLoggers` fails intermittently in CI. The test executes MSBuild twice - once with terminal logger, once without - then compares binary logs to verify identical behavior. The test had two sources of flakiness: parallel builds causing non-deterministic event ordering, and a fragile assertion comparing all internal events. ### Changes Made - Removed `/m` flag from both MSBuild invocations to make builds deterministic - Removed `AllBuildEvents.Count` assertion that was checking internal implementation details - Test now runs sequentially and validates only meaningful build behavior (errors, warnings, items, properties) ### Testing - Built repository successfully - Test passed consistently across 10+ consecutive runs - Verified that all meaningful assertions continue to validate correct terminal logger behavior ### Notes The fix addresses both root causes of flakiness. The `AllBuildEvents.Count` comparison was too strict - internal events (like assembly loading, telemetry, logger initialization) can legitimately vary between runs based on environment and logger configuration without indicating a problem. The test now focuses on verifying that terminal logger doesn't affect build outcomes (errors, warnings, evaluation results) rather than internal event counts.

Original prompt

> > ---- > > *This section details on the original issue you should resolve* > > Test TestTerminalLoggerTogetherWithOtherLoggers is flaky > In the recent runs the test TestTerminalLoggerTogetherWithOtherLoggers fails from time to time. > Fix it or disable if the root cause isn't clear. > > ## Comments on the Issue (you are @copilot in this section) > > > >

- Fixes dotnet/msbuild#13043 --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: YuliiaKovalova <95473390+YuliiaKovalova@users.noreply.github.com>

Test TestTerminalLoggerTogetherWithOtherLoggers is flaky #13043

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions