Skip to content

Common.targets doesn't promote TreatWarningsAsErrors to MSBuildTreatWarningsAsErrors #10871

Open
Open
Common.targets doesn't promote TreatWarningsAsErrors to MSBuildTreatWarningsAsErrors#10871
Assignees
rainersigwaldSimaTian
Labels
Priority:1Work that is critical for the release, but we could probably ship withouttriaged
@rainersigwald

Description

@rainersigwald
rainersigwald
opened on Oct 23, 2024

Common.targets does respect the "plain property" version of some warning-related settings:

msbuild/src/Tasks/Microsoft.Common.CurrentVersion.targets

Lines 668 to 672 in 69b3e7a

<PropertyGroup>
<MSBuildWarningsAsMessages Condition="'$(MSBuildWarningsAsMessages)'==''">$(NoWarn)</MSBuildWarningsAsMessages>
<MSBuildWarningsAsErrors Condition="'$(MSBuildWarningsAsErrors)'==''">$(WarningsAsErrors)</MSBuildWarningsAsErrors>
<MSBuildWarningsNotAsErrors Condition="'$(MSBuildWarningsNotAsErrors)'==''">$(WarningsNotAsErrors)</MSBuildWarningsNotAsErrors>
</PropertyGroup>

but it doesn't do the broader setting MSBuildTreatWarningsAsErrors in the same way.

This adds to the confusion about which settings to use.

Metadata

Metadata

Assignees

Labels

Priority:1Work that is critical for the release, but we could probably ship withouttriaged

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions