Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/msbuild
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e2dabce
Choose a base ref
...
head repository: dotnet/msbuild
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a440ea9
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Oct 10, 2022

  1. Fallback when server client fails due to mutex connection timeout err… 

    …or. (#8024)

Fixes #7993

Summary
In the MSBuild server, we identify the state of the server via mutexes. Sometimes, for reason yet unknown to us, mutex could throw the exception System.IO.IOException: Connection timed out. When this occurs, we fallback to old behavior building without server. We fixed some of those in #8000, but now found more situations when this happens.

Customer Impact
MSBuild non-Windows users could have intermittent error when building with dotnet build.
This does not affect Visual Studio.

Regression?
Yes, this is a regression.

Testing
Unit tests.

Risk
Low risk. The fix adds additional try-catch blocks to process this situation.

Code Reviewers
[TODO]

Description of the fix
Add a try-catch block to catch and process the IOException exception when mutexes are used.
Add a new client exit type for this kind of error.
    @AR-May
    AR-May authored Oct 10, 2022
    Configuration menu
    Copy the full SHA
    a440ea9 View commit details
    Browse the repository at this point in the history
Loading