Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/msbuild
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 428195cb74
Choose a base ref
...
head repository: dotnet/msbuild
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 00b81e71d5
Choose a head ref
  • 5 commits
  • 18 files changed
  • 4 contributors

Commits on Mar 6, 2025

  1. Update .NET Framework references to 9.0.0 (#11145)

    * Update .NET Framework references to 9.0.0
    
    * OK fine update sourcebuild too
    
    * fixup! OK fine update sourcebuild too
    
    * fixup! OK fine update sourcebuild too
    
    * Add new dependencies
    
    * Formats.Nrbf depends on Bcl.HashCode
    
    * Don't ngen S.Resources.Extensions
    
    This is ngen-ing in vsn context but it shouldn't
    ever be used from the amd64 directory; that copy is for compat with
    badly-written API users only.
    
    * SRE pkgdef version bump too
    
    * Official Build MpPreference workaround (#11464)
    
    Try disabling AV in the official build script to avoid build breaks that manifest as
    
    ```
    D:\a\_work\1\s\.packages\microsoft.dotnet.arcade.sdk\9.0.0-beta.24516.2\tools\Sign.proj(72,5): error MSB4018: The "Microsoft.DotNet.SignTool.SignToolTask" task failed unexpectedly.
    System.Runtime.Serialization.SerializationException: Type 'System.AssemblyLoadEventArgs' in assembly 'mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' is not marked as serializable.
       at Microsoft.Build.BackEnd.Components.RequestBuilder.AssemblyLoadsTracker.CurrentDomainOnAssemblyLoad(Object sender, AssemblyLoadEventArgs args)
       at System.AppDomain.OnAssemblyLoadEvent(RuntimeAssembly LoadedAssembly)
       at Microsoft.Build.Framework.ITask.Execute()
       at Microsoft.Build.BackEnd.TaskExecutionHost.Execute()
       at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext() [D:\a\_work\1\s\.packages\microsoft.dotnet.arcade.sdk\9.0.0-beta.24516.2\tools\Sign.proj]
    ```
    
    ---------
    
    Co-authored-by: Jan Provaznik <janprovaznik@microsoft.com>
    
    * Add DiagnosticSource to SB baseline
    
    * One DiagnosticSource
    
    ---------
    
    Co-authored-by: Jan Provaznik <janprovaznik@microsoft.com>
    rainersigwald and JanProvaznik authored Mar 6, 2025
    Configuration menu
    Copy the full SHA
    353c0f3 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2025

  1. [CodeQL][SM03800] Remove unapproved usage of DSACryptoServiceProvider (

    …#11540)
    
    Fixes #
    CodeQL SM03800 issue
    
    Context
    CodeQL is flagging unapproved usage of DSACryptoServiceProvider
    
    Changes Made
    The flagged code is not required in ClickOnce so deleting it.
    
    Testing
    ClickOnce signing scenarios validated from .NET Fx 3.5 through .NET 9.
    
    Notes
    sujitnayak authored Mar 7, 2025
    Configuration menu
    Copy the full SHA
    e837c39 View commit details
    Browse the repository at this point in the history
  2. Opt-in .sln parsing with Microsoft.VisualStudio.SolutionPersistence (#…

    …11538)
    
    * revert "Revert ".slnx support - use the new parser for .sln and .slnx (#10836)""
    
    * opt-in sln parsing with SolutionPersistence
    
    * add SlnParsingWithSolutionPersistenceOptIn to Traits
    
    * bring back comment about revertin .sln parsing with SolutionPersistence in ChangeWaves
    
    * fix tests
    
    * remove empty line
    
    * opt-in and -out of sln parsing with the new parser in SolutionFileTests
    
    * fix tests without using common testenv
    
    * fix tests
    
    * fix
    
    * rename env var to MSBUILD_PARSE_SLN_WITH_SOLUTIONPERSISTENCE
    
    * fix closing bracket
    
    * change ParseSolutionHelper to call SolutionFile.Parse
    surayya-MS authored Mar 7, 2025
    Configuration menu
    Copy the full SHA
    0e528f7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cce4d88 View commit details
    Browse the repository at this point in the history
  4. Load before/after.{solutionName}.sln.targets for .slnx (#11535)

    added test checking that targets from these files are included in the project
    surayya-MS authored Mar 7, 2025
    Configuration menu
    Copy the full SHA
    00b81e7 View commit details
    Browse the repository at this point in the history
Loading