Remove fragile AllBuildEvents.Count assertion

Copilot · YuliiaKovalova · Copilot · commit 8f0a4b66d9d0 · 2026-01-16T16:17:06.000Z
The AllBuildEvents.Count comparison was causing flakiness because internal events can vary between runs based on environment, logger configuration, and MSBuild internals. The meaningful assertions (errors, warnings, items, properties) are already verified.

Co-authored-by: YuliiaKovalova &lt;95473390+YuliiaKovalova@users.noreply.github.com&gt;
diff --git a/src/Build.UnitTests/TerminalLogger_Tests.cs b/src/Build.UnitTests/TerminalLogger_Tests.cs
@@ -935,10 +935,10 @@ public void TestTerminalLoggerTogetherWithOtherLoggers()
                 binaryLogReaderWithTL.Replay(logFileWithTL);
                 binaryLogReaderWithoutTL.Replay(logFileWithoutTL);
 
-                // Check that amount of events, warnings, errors is equal in both cases. Presence of other loggers should not change behavior
+                // Check that amount of warnings and errors is equal in both cases. Presence of other loggers should not change behavior
                 mockLogFromPlaybackWithoutTL.Errors.Count.ShouldBe(mockLogFromPlaybackWithTL.Errors.Count);
                 mockLogFromPlaybackWithoutTL.Warnings.Count.ShouldBe(mockLogFromPlaybackWithTL.Warnings.Count);
-                mockLogFromPlaybackWithoutTL.AllBuildEvents.Count.ShouldBe(mockLogFromPlaybackWithTL.AllBuildEvents.Count);
+                // Note: We don't compare AllBuildEvents.Count because internal events can vary between runs and with different logger configurations
 
                 // Check presence of some items and properties and that they have at least 1 item and property
                 mockLogFromPlaybackWithoutTL.EvaluationFinishedEvents.ShouldContain(x => (x.Items != null) && x.Items.GetEnumerator().MoveNext());
