[Android] Fix crash when opening a TabbedPage from a ContentPage that is referenced in Shell#9213
Closed
maxkoshevoi wants to merge 1 commit intodotnet:mainfrom
Closed
[Android] Fix crash when opening a TabbedPage from a ContentPage that is referenced in Shell#9213maxkoshevoi wants to merge 1 commit intodotnet:mainfrom
TabbedPage from a ContentPage that is referenced in Shell#9213maxkoshevoi wants to merge 1 commit intodotnet:mainfrom
Conversation
|
Hey there @maxkoshevoi! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
2 similar comments
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
Could someone look at this one please? It's a blocker for me for migrating an app to MAUI since TabbedPage just throws NRE when opened |
Member
|
The latest version of
I can't really give a confident timeline on when the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Starting from MAUI 6.0.408 there's an NRE here when trying to open a
TabbedPagefrom aContentPagethat is referenced inShell.maui/src/Controls/src/Core/Platform/Android/TabbedPageManager.cs
Line 240 in ea8e7d2
This will fix it (not sure if
TabbedPagewould start working, don't know how to test that).Issues Fixed
Related to #7615