Skip to content

Regenerate splash screen on changes and respect alias#7993

Closed
mattleibow wants to merge 5 commits intonet6.0from
dev/splash-story
Closed

Regenerate splash screen on changes and respect alias#7993
mattleibow wants to merge 5 commits intonet6.0from
dev/splash-story

Conversation

@mattleibow
Copy link
Copy Markdown
Member

@mattleibow mattleibow commented Jun 13, 2022

NOTE: merge after #7994

Description of Change

Currently if you make any changes to the MauiSplashScreen properties (such as set a foreground tint) then it does not actually trigger a new splash to be generated.

Also, on iOS and Mac Catalyst, the generated storyboard does not actually use the new image if there was an alias/Link set.

Issues Fixed

@mattleibow mattleibow added the area-single-project Splash Screen, Multi-Targeting, MauiFont, MauiImage, MauiAsset, Resizetizer label Jun 13, 2022
@mattleibow mattleibow added this to the 6.0-sr2 milestone Jun 13, 2022
@mattleibow mattleibow self-assigned this Jun 13, 2022
@mattleibow mattleibow changed the base branch from dev/inject-android-icons to net6.0 June 13, 2022 15:29
@mattleibow mattleibow requested a review from a team as a code owner June 13, 2022 15:29
@mattleibow mattleibow changed the title Regenerate splash screen on changes and respect iOS alias Regenerate splash screen on changes and respect alias Jun 13, 2022
@mattleibow mattleibow marked this pull request as draft June 13, 2022 15:36
@mattleibow
Copy link
Copy Markdown
Member Author

Closed in favor of: #8020

@mattleibow mattleibow closed this Jun 14, 2022
@mattleibow mattleibow deleted the dev/splash-story branch June 14, 2022 17:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-single-project Splash Screen, Multi-Targeting, MauiFont, MauiImage, MauiAsset, Resizetizer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resizetizer does not respect splash screen alias SplashScreen does not regenerate after changing properties (Color/ForegroundScale)

1 participant