Automatically add MauiIcon to AndroidManifest.xml#7968
Closed
mattleibow wants to merge 1 commit intonet6.0from
Closed
Automatically add MauiIcon to AndroidManifest.xml#7968mattleibow wants to merge 1 commit intonet6.0from
mattleibow wants to merge 1 commit intonet6.0from
Conversation
This was referenced Jun 12, 2022
Member
Author
|
Closed in favor of #8020 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
On Android (and iOS / Mac Catalyst) the app icons are not actually added to the manifests because that code was not written. For some reason I had determined that people would always use the same filename and thus the templates would be good - and somehow knowledge would arrive in the brains of devs to go change values in the platform files when editing the csproj.
This was obviously wrong and even though the docs are technically incorrect because they do not state that you have to change values in the manifest, this PR goes ahead and does the expected thing and makes sure there is an icon in the manifest.
Issues Fixed