Skip to content

Automatically add MauiIcon to AndroidManifest.xml#7968

Closed
mattleibow wants to merge 1 commit intonet6.0from
dev/inject-android-icons
Closed

Automatically add MauiIcon to AndroidManifest.xml#7968
mattleibow wants to merge 1 commit intonet6.0from
dev/inject-android-icons

Conversation

@mattleibow
Copy link
Copy Markdown
Member

@mattleibow mattleibow commented Jun 12, 2022

Description of Change

On Android (and iOS / Mac Catalyst) the app icons are not actually added to the manifests because that code was not written. For some reason I had determined that people would always use the same filename and thus the templates would be good - and somehow knowledge would arrive in the brains of devs to go change values in the platform files when editing the csproj.

This was obviously wrong and even though the docs are technically incorrect because they do not state that you have to change values in the manifest, this PR goes ahead and does the expected thing and makes sure there is an icon in the manifest.

NOTE: the Android templates change here to no longer explicitly set the icon in the working directory, but existing users will still have it. This needs to be documented on how to remove and/or specify: dotnet/docs-maui#611

Issues Fixed

@mattleibow
Copy link
Copy Markdown
Member Author

Closed in favor of #8020

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-single-project Splash Screen, Multi-Targeting, MauiFont, MauiImage, MauiAsset, Resizetizer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android does not automatically update the manifests with MauiIcon

1 participant