Skip to content

Enable Controls CoreCLR device tests on iOS and Catalyst#34571

Merged
PureWeen merged 2 commits intonet11.0from
enable-coreclr-controls-device-tests
Mar 24, 2026
Merged

Enable Controls CoreCLR device tests on iOS and Catalyst#34571
PureWeen merged 2 commits intonet11.0from
enable-coreclr-controls-device-tests

Conversation

@kotlarmilos
Copy link
Copy Markdown
Member

@kotlarmilos kotlarmilos commented Mar 19, 2026 •
edited
Loading

Description

Re-enable Controls device tests on CoreCLR for Apple mobile

Fixes dotnet/runtime#122219

@kotlarmilos
Enable Controls CoreCLR device tests on iOS and Catalyst
a969713 
Re-enable Controls device tests on CoreCLR for iOS (simulator-18.4) and
MacCatalyst (latest) that were disabled due to dotnet/runtime#122219.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 19, 2026 15:36
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 19, 2026 •
edited
Loading

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34571

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34571"

kotlarmilos
kotlarmilos commented Mar 19, 2026
View reviewed changes
kotlarmilos
kotlarmilos commented Mar 19, 2026
View reviewed changes
@kotlarmilos
Apply suggestions from code review
9870041 
Co-authored-by: Milos Kotlar <kotlarmilos@gmail.com>
Copilot AI reviewed Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-enables running Controls device tests under CoreCLR for iOS (simulator-18.4) and MacCatalyst (latest) by removing the version-specific CoreCLR exclusions that were previously added as a workaround for dotnet/runtime#122219.

Changes:

  • Removed iosVersionsCoreClrExclude for the Controls device test scenario.
  • Removed catalystVersionsCoreClrExclude for the Controls device test scenario.
  • Consolidated the prior tracking comments into a single “re-enabled” note referencing the runtime issue.

You can also share your feedback on Copilot code review. Take the survey.

@kotlarmilos kotlarmilos self-assigned this Mar 19, 2026
@github-actions github-actions bot mentioned this pull request Mar 20, 2026
Closed
@kotlarmilos
Copy link
Copy Markdown
Member Author

kotlarmilos commented Mar 20, 2026

/azp run maui-pr-uitests, maui-pr-devicetests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Mar 20, 2026

Azure Pipelines successfully started running 2 pipeline(s).

This was referenced Mar 20, 2026
Open
Open
Open
Open
Open
This was referenced Mar 21, 2026
Closed
Closed
@kotlarmilos
Copy link
Copy Markdown
Member Author

kotlarmilos commented Mar 23, 2026

Tests are passing on device

[12:32:22.5734250] 2026-03-20 12:32:22.573304-0400 Microsoft.Maui.Controls.DeviceTests[24311:1791632] Tests run: 697 Passed: 575 Inconclusive: 0 Failed: 0 Ignored: 122

@build-analysis build-analysis bot mentioned this pull request Mar 23, 2026
Open
@kotlarmilos
Copy link
Copy Markdown
Member Author

kotlarmilos commented Mar 24, 2026 •
edited
Loading

CI failures are on unrelated platforms; CoreCLR iOS device tests pass

@PureWeen PureWeen merged commit 7a58b97 into net11.0 Mar 24, 2026
194 of 209 checks passed
@PureWeen PureWeen deleted the enable-coreclr-controls-device-tests branch March 24, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@kubaflo kubaflo kubaflo approved these changes

@PureWeen PureWeen Awaiting requested review from PureWeen

Assignees

@kotlarmilos kotlarmilos

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kotlarmilos @rolfbjarne @kubaflo @PureWeen