Skip to content

[Testing] Additional Feature Matrix Event Test Cases for Slider and ScrollView#34352

Open
nivetha-nagalingam wants to merge 2 commits intodotnet:mainfrom
nivetha-nagalingam:nivetha-ScrollView-Slider-events
Open

[Testing] Additional Feature Matrix Event Test Cases for Slider and ScrollView#34352
nivetha-nagalingam wants to merge 2 commits intodotnet:mainfrom
nivetha-nagalingam:nivetha-ScrollView-Slider-events

Conversation

@nivetha-nagalingam
Copy link
Contributor

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

This PR enhances the event handling support for multiple MAUI controls by adding comprehensive implementation and validation for control-specific events, along with corresponding test coverage.

The update includes the addition of events for Slider and ScrollView controls, ensuring proper event triggering and argument handling across different platforms.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34352

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34352"

@Ahamed-Ali Ahamed-Ali added community ✨ Community Contribution area-testing Unit tests, device tests area-controls-stepper Stepper area-controls-slider Slider area-controls-scrollview ScrollView and removed area-controls-stepper Stepper labels Mar 6, 2026
@dotnet-policy-service
Copy link
Contributor

Hey there @@nivetha-nagalingam! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Mar 6, 2026
@sheiksyedm sheiksyedm marked this pull request as ready for review March 6, 2026 14:23
Copilot AI review requested due to automatic review settings March 6, 2026 14:23
@sheiksyedm
Copy link
Contributor

/azp run maui-pr-uitests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the Feature Matrix coverage for MAUI controls by adding HostApp plumbing and UI tests that validate Slider.ValueChanged and ScrollView.ScrollToRequested event behavior and arguments.

Changes:

  • Added Slider.ValueChanged event tracking (raised/not-raised + old/new values) in the Slider Feature Matrix HostApp page and corresponding UI tests.
  • Added ScrollView.ScrollToRequested event tracking (requested X/Y/position/animate/mode/element) in the ScrollView Feature Matrix HostApp page and corresponding UI tests.
  • Updated one Android screenshot baseline impacted by the Slider page UI changes.

Reviewed changes

Copilot reviewed 8 out of 251 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/SliderFeatureTests.cs Adds UI tests validating Slider ValueChanged status and arguments.
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/ScrollViewFeatureTests.cs Adds UI tests validating ScrollView ScrollToRequested event and argument values.
src/Controls/tests/TestCases.HostApp/FeatureMatrix/Slider/SliderViewModal.cs Adds bindable properties for Slider ValueChanged status + old/new values.
src/Controls/tests/TestCases.HostApp/FeatureMatrix/Slider/SliderControlPage.xaml.cs Hooks Slider ValueChanged to update the view model properties.
src/Controls/tests/TestCases.HostApp/FeatureMatrix/Slider/SliderControlPage.xaml Adds UI labels/AutomationIds for the new Slider event state/args.
src/Controls/tests/TestCases.HostApp/FeatureMatrix/ScrollView/ScrollViewViewModel.cs Adds bindable properties for ScrollToRequested status/args.
src/Controls/tests/TestCases.HostApp/FeatureMatrix/ScrollView/ScrollViewControlPage.xaml.cs Handles ScrollToRequested and adds a pixel-scroll trigger button handler.
src/Controls/tests/TestCases.HostApp/FeatureMatrix/ScrollView/ScrollViewControlPage.xaml Adds UI labels/AutomationIds for the new ScrollToRequested status/args and pixel-scroll trigger.
src/Controls/tests/TestCases.Android.Tests/snapshots/android/Slider_SetVisibilityToFalse_VerifyVisualState.png Updates Android screenshot baseline for a Slider visual test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-controls-scrollview ScrollView area-controls-slider Slider area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants