Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates macOS pool configuration in Azure Pipelines by removing the separate MacOSPoolArm64 parameter and introducing conditional pool selection based on build definition. The change allows the pipeline to use different pools for public PRs (maui-pr) versus internal builds.
Changes:
- Consolidated
MacOSPoolandMacOSPoolArm64parameters into a singleMacOSPoolparameter withinternalandpublicconfigurations - Added conditional logic to all macOS job stages to select between public and internal pools based on whether the build definition is
maui-pr
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
/backport to release/11.0.1xx-preview1 |
Contributor
|
Started backporting to |
Contributor
|
@rmarinho backporting to git am output$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
ACES doesn t existing on the internal dnceng so we need to keep what we had.
This pull request updates the Azure Pipelines configuration for macOS jobs to simplify pool selection and improve flexibility. The main change is the removal of the separate
MacOSPoolArm64parameter and the introduction of conditional logic to select between internal and public macOS pools based on the build definition. This allows all macOS test and build stages to use a unified pool configuration, streamlining maintenance and making it easier to manage resources for different build scenarios.Key changes:
Pipeline Pool Configuration:
MacOSPoolArm64parameter and consolidated macOS pool definitions into a singleMacOSPoolparameter withinternalandpublicoptions.Conditional Pool Selection in Stages:
'maui-pr', thepublicpool is used; otherwise, theinternalpool is used. [1] [2] [3] [4] [5] [6]