[Android] Reset content margin on TabbedPage disappearing without removing tabs#33031
Merged
jfversluis merged 2 commits into30290-1from Dec 8, 2025
Merged
[Android] Reset content margin on TabbedPage disappearing without removing tabs#33031jfversluis merged 2 commits into30290-1from
jfversluis merged 2 commits into30290-1from
Conversation
…bottom margin on Disappearing Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with tabs removal during modal navigation on Android
[Android] Reset content margin on TabbedPage disappearing without removing tabs
Dec 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Fixes the
NavigatingAwayFromTabbedPageResizesContentPagedevice test failure while preserving the modal navigation fix.Root cause: The PR removed
OnTabbedPageDisappearingentirely, which prevented both tab removal (desired) and bottom margin reset (needed). When navigating away from a TabbedPage with bottom tabs, the content margin remained set, causing subsequent pages to not use full screen height.Solution: Re-enabled
OnTabbedPageDisappearingto callSetContentBottomMargin(0)without callingRemoveTabs(). This ensures:Issues Fixed
Fixes CommunityToolkit/Maui#2708
Closes #30290
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.