Skip to content

[Android] Prevent tabs from being removed during Disappearing#32958

Merged
jfversluis merged 2 commits into30290-1from
copilot/sub-pr-32878-another-one
Dec 2, 2025
Merged

[Android] Prevent tabs from being removed during Disappearing#32958
jfversluis merged 2 commits into30290-1from
copilot/sub-pr-32878-another-one

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 2, 2025

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

On Android, tabs were being removed from layout during modal navigation due to a Disappearing event handler calling RemoveTabs(). This caused the tab bar to vanish when showing modal pages or popups on a TabbedPage.

Fix:

  • Removed the OnTabbedPageDisappearing event handler registration and method from TabbedPageManager.cs
  • Aligns Android behavior with iOS where tabs remain visible during modal navigation

UI Test:

  • Uses VerifyScreenshot() to validate tabs remain visible when modal is open
  • Modal uses semi-transparent background (#80000000) so tabs are visible behind it in screenshot verification

Issues Fixed

Fixes #30290

Fixes CommunityToolkit/Maui#2708


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…le during modal navigation

Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix tab removal during modal navigation on Android [Android] Prevent tabs from being removed during Disappearing Dec 2, 2025
Copilot AI requested a review from jfversluis December 2, 2025 13:21
@jfversluis jfversluis marked this pull request as ready for review December 2, 2025 13:34
@jfversluis jfversluis merged commit 1b1c479 into 30290-1 Dec 2, 2025
1 check passed
@jfversluis jfversluis deleted the copilot/sub-pr-32878-another-one branch December 2, 2025 13:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants