Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds localized translations for two new resource strings (RequiredPropertyTitle and RequiredPropertyMessage) related to the 'required' keyword warning in XAML, and removes the InstFlg="true" attribute from the DuplicateKeyInRD item across multiple language localization files.
- Adds translations for warning users about limited 'required' keyword support in XAML
- Normalizes the
DuplicateKeyInRDitem by removing theInstFlg="true"attribute for consistency
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| loc/zh-Hans/src/Controls/src/SourceGen/MauiGResources.resx.lcl | Adds Chinese (Simplified) translations for RequiredProperty strings and removes InstFlg from DuplicateKeyInRD |
| loc/tr/src/Controls/src/SourceGen/MauiGResources.resx.lcl | Adds Turkish translations for RequiredProperty strings and removes InstFlg from DuplicateKeyInRD |
| loc/pt-BR/src/Controls/src/SourceGen/MauiGResources.resx.lcl | Adds Brazilian Portuguese translations for RequiredProperty strings and removes InstFlg from DuplicateKeyInRD |
| loc/pl/src/Controls/src/SourceGen/MauiGResources.resx.lcl | Adds Polish translations for RequiredProperty strings and removes InstFlg from DuplicateKeyInRD |
| loc/ja/src/Controls/src/SourceGen/MauiGResources.resx.lcl | Adds Japanese translations for RequiredProperty strings and removes InstFlg from DuplicateKeyInRD |
| loc/it/src/Controls/src/SourceGen/MauiGResources.resx.lcl | Adds Italian translations for RequiredProperty strings and removes InstFlg from DuplicateKeyInRD |
| loc/fr/src/Controls/src/SourceGen/MauiGResources.resx.lcl | Adds French translations for RequiredProperty strings and removes InstFlg from DuplicateKeyInRD |
| loc/es/src/Controls/src/SourceGen/MauiGResources.resx.lcl | Adds Spanish translations for RequiredProperty strings and removes InstFlg from DuplicateKeyInRD |
rmarinho
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEGO: Pull request from lego/hb_7241b85a-f216-4d55-a9fa-d8030c736df5_20251106003630659 to main with localized lcls