Android: reduce Java to .NET layout pass calls (alternative)#31776
Closed
albyrock87 wants to merge 2 commits intodotnet:net10.0from
Closed
Android: reduce Java to .NET layout pass calls (alternative)#31776albyrock87 wants to merge 2 commits intodotnet:net10.0from
albyrock87 wants to merge 2 commits intodotnet:net10.0from
Conversation
Contributor
|
Hey there @@albyrock87! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
d0585b5 to
ef1385d
Compare
ef1385d to
cf81c7a
Compare
albyrock87
commented
Sep 26, 2025
src/Core/AndroidNative/maui/src/main/java/com/microsoft/maui/PlatformContentViewGroup.java
Show resolved
Hide resolved
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Nov 7, 2025
Contributor
jsuarezruiz
left a comment
There was a problem hiding this comment.
@albyrock87 Could you rebase to fix the conflict?
Contributor
Author
|
I'll decline this because it doesn't show substantial performance increase, at least with my benchmarks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This is an alternative for #31595 which aims to further reduce java interop.
Instead of preparing the measure for the actual
Android.Views.View.Measurecall, we invoke a custom measure method which eventually returns a special flag telling us whether a measure is needed.If it is, we run the cross-platform-layout measure method and store the result by using an internal
OverrideMeasuredDimension.Benchmarks
Benchmarks are totally unreliable, I tried multiple times and I always get different results.