[Windows] Allow to remove clip at runtime#31488
Merged
PureWeen merged 4 commits intodotnet:inflight/candidatefrom Sep 10, 2025
Merged
Conversation
MartyIX
commented
Sep 5, 2025
MartyIX
commented
Sep 5, 2025
|
|
||
| if (clipGeometry is null) | ||
| { | ||
| DisposeClip(); |
Contributor
Author
There was a problem hiding this comment.
This is the main change.
Contributor
Author
There was a problem hiding this comment.
See https://github.com/dotnet/maui/blob/main/src/Controls/tests/TestCases.Android.Tests/snapshots/android/Issue24414Test_4.png to compare Android and Windows behavior. Windows behavior is now aligned to the Android one.
Contributor
Author
|
@jfversluis @jsuarezruiz Could you please run tests to see if something breaks/improves? |
Member
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dc68b9d to
482286e
Compare
482286e to
2ed79b3
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
MartyIX
commented
Sep 7, 2025
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/Issue24414Test_4.png
Show resolved
Hide resolved
MartyIX
commented
Sep 7, 2025
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/Issue24414Test_5.png
Show resolved
Hide resolved
MartyIX
commented
Sep 7, 2025
...ests/TestCases.WinUI.Tests/snapshots/windows/FlyoutMenuCollectionViewFirstItemMisaligned.png
Show resolved
Hide resolved
MartyIX
commented
Sep 7, 2025
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/WebViewShouldNotMirrored.png
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 3 pipeline(s). |
cf9d482 to
390cb46
Compare
1712dae to
8e266f5
Compare
390cb46 to
c6cb675
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/rebase |
|
probably the failing tests are related to the inflight/candidate branch, which was updated recently with a lot of new commits |
Contributor
Author
|
Yeah, the inflight branch contains a lot of failing tests: https://github.com/dotnet/maui/pull/31525/checks 
|
PureWeen
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
While researching #18337, I noticed that shadows do not disappear (merged in #31452) and then I noticed that
Clipappears to suffer from the same issue.This PR targets the
inflight/currentbranch because #31452 was merged there and that PR affects the same test -- i.e.Issue24414-- as this PR does.