Fixed Test case failure in PR 31327#31378
Merged
jfversluis merged 1 commit intodotnet:inflight/candidatefrom Aug 28, 2025
Merged
Fixed Test case failure in PR 31327#31378jfversluis merged 1 commit intodotnet:inflight/candidatefrom
jfversluis merged 1 commit intodotnet:inflight/candidatefrom
Conversation
jfversluis
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue Details
In the failed test
AppDoesntCrashWhenSettingNewTitleViewOnExistingPage, the TitleView was updated in the OnAppearing method. When popping the page using PopAsync, the OnAppearing event is triggered twice with my fix, whereas previously it was triggered only once: once from FireAppearing and once from CurrentPageChanged.This additional trigger causes the title to mismatch the expected value, resulting in the test failure.
Root Cause
The fix moves FireAppearing to after RemoveFromInnerChildren(page), but at that point InternalChildren.Last() has already changed. Currently, StackDepth - 2 is calculated based on the original stack depth. Once the popped page is removed from stack, accessing InternalChildren[StackDepth - 2] is not valid.
Description of Change
Remove the page first, then use InternalChildren.Last(); directly to get the correct page that should appear.
Regressed PR: #28666
Fixes AppDoesntCrashWhenSettingNewTitleViewOnExistingPage test failure in PR: #31327
Screenshots