Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts template changes that were made to the DeveloperBalance template in the samples repository. The PR author is reverting these changes until the team is satisfied with the DeveloperBalance template implementation.
- Reverts template-related changes to maintain consistency until final approval
- Fixes a typo in logging method name from "ReponseContentNotFound" to "ResponseContentNotFound"
- Removes a project reference and updates various BlazorWebView implementation files
Reviewed Changes
Copilot reviewed 289 out of 2567 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| BlazorWebViewTests.Components.cs | Adds new test file for Blazor component functionality |
| BlazorWebViewTests.Behaviors.cs | Adds new test file for iOS/Mac Catalyst scroll behavior testing |
| _Imports.razor | Adds new Razor imports file for test components |
| WebView2WebViewManager.cs | Updates web resource filter and fixes typo in logging method |
| Log.cs | Fixes typo in logging method name from "ReponseContentNotFound" to "ResponseContentNotFound" |
| IOSWebViewManager.cs | Adds comprehensive updates for iOS WebView implementation |
| BlazorWebViewHandler.iOS.cs | Updates iOS handler with scroll behavior and request interception |
| WinUIWebViewManager.cs | Adds request interception logic for Windows platform |
| Multiple PublicAPI files | Updates public API surface with WebResourceRequested event |
| IBlazorWebView.cs | Adds interface inheritance for web request interception |
| BlazorWebView.cs | Implements web resource request event handling |
| Multiple Android files | Updates Android WebView implementation with request interception |
| BlazorWinFormsApp.csproj | Removes IsTestProject property |
| Multiple localization files | Updates various template translations |
|
|
||
| [LoggerMessage(EventId = 6, Level = LogLevel.Debug, Message = "Response content was not found for web request to URI '{requestUri}'.")] | ||
| public static partial void ReponseContentNotFound(this ILogger logger, string requestUri); | ||
| public static partial void ResponseContentNotFound(this ILogger logger, string requestUri); |
There was a problem hiding this comment.
This method name was corrected from 'ReponseContentNotFound' to 'ResponseContentNotFound' which is a good fix for the typo.
| @@ -1 +1,2 @@ | |||
| #nullable enable | |||
| Microsoft.AspNetCore.Components.WebView.Maui.BlazorWebView.WebResourceRequested -> System.EventHandler<Microsoft.Maui.Controls.WebViewWebResourceRequestedEventArgs!>? | |||
There was a problem hiding this comment.
This addition of a public API event 'WebResourceRequested' represents a potentially breaking change to the public API surface. Per coding guideline 256, breaking changes should not be made in minor versions or service releases.
3a03582 to
9e0202c
Compare
mattleibow
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Reverting this until we are all happy with the DeveloperBalance template in the samples repository