[iOS] Fix TimePicker AM/PM frequently changes when the app is closed and reopened by devanathan-vaithiyanathan · Pull Request #31066 · dotnet/maui

devanathan-vaithiyanathan · 2025-08-07T13:01:35Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Details

The TimePicker was not showing AM/PM correctly after restarting the app when using the format "HH:mm tt".

Description of Change

We now use the same culture for both the display text and the TimePicker control to ensure consistency. When the format includes AM/PM, we use the en-US culture. For 24-hour formats, we use the de-DE culture.

Issues Fixed

Fixes #30837
Fixes #33722

Tested the behavior in the following platforms.

Android
Windows
iOS
Mac

Before	After
iOS iOS-Before.mov	iOS iOS-After.mov

dotnet-policy-service · 2025-08-07T13:01:55Z

Hey there @@devanathan-vaithiyanathan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copilot

Pull Request Overview

This PR fixes an issue where the TimePicker on iOS would incorrectly display AM/PM values after restarting the app when using 12-hour time formats. The solution ensures consistent culture usage between the display text and the native iOS picker control.

Key Changes:

Refactored culture selection logic to use a consistent culture for both text formatting and picker locale
Simplified the culture determination by checking for AM/PM indicators ('t') or 12-hour format ('h') to use en-US culture
Added comprehensive UI tests to validate the TimePicker behavior

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/Core/src/Platform/iOS/TimePickerExtensions.cs	Refactored the UpdateTime method to use consistent culture selection for both text display and picker locale
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue30837.cs	Added UI test to verify TimePicker format consistency
src/Controls/tests/TestCases.HostApp/Issues/Issue30837.cs	Created test page with TimePicker using 12-hour format to reproduce the issue

Copilot · 2025-08-12T13:43:26Z

src/Core/src/Platform/iOS/TimePickerExtensions.cs

+			}
+
+			// Apply the same culture to both the text display and the picker
+			mauiTimePicker.Text = time.ToFormattedString(format ?? string.Empty, formattingCulture);


Using string.Empty as fallback when format is null may cause issues. The original code passed format directly to ToFormattedString, which likely handles null formats appropriately. Consider using format directly or verify that ToFormattedString handles empty strings the same way as null.

Suggested change

mauiTimePicker.Text = time.ToFormattedString(format ?? string.Empty, formattingCulture);

mauiTimePicker.Text = time.ToFormattedString(format, formattingCulture);

jsuarezruiz · 2025-08-28T14:54:12Z

/azp run MAUI-UITests-public

jsuarezruiz · 2025-08-28T14:54:16Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-08-28T14:54:25Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2025-08-28T14:54:27Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz

Pending snapshots for all the platforms.

Already available in the latest build. Could you commit the images?

devanathan-vaithiyanathan · 2025-09-01T10:26:48Z

Pending snapshots for all the platforms.

Already available in the latest build. Could you commit the images?

@jsuarezruiz , I've added the snapshots

jsuarezruiz · 2025-10-10T10:34:26Z

/azp run MAUI-DeviceTests-public

azure-pipelines · 2025-10-10T10:34:37Z

Azure Pipelines successfully started running 1 pipeline(s).

jfversluis · 2025-10-21T15:00:25Z

/rebase

azure-pipelines · 2025-10-21T15:03:24Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2025-10-22T12:27:25Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2025-10-22T19:29:04Z

Azure Pipelines successfully started running 1 pipeline(s).

This reverts commit 138797f.

github-actions · 2026-03-03T21:23:40Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 31066

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 31066"

kubaflo

Hi! Could you please add iOS-26 screenshots?

kubaflo · 2026-03-03T21:24:10Z

/azp run

azure-pipelines · 2026-03-03T21:24:29Z

Azure Pipelines successfully started running 3 pipeline(s).

Co-Authored-By: Copilot <223556219+Copilot@users.noreply.github.com>

devanathan-vaithiyanathan · 2026-03-04T07:50:35Z

Hi! Could you please add iOS-26 screenshots?

@kubaflo , I have added the iOS 26 snapshot.

kubaflo

Hi! Could you please apply the AI Summary suggestions?

Co-Authored-By: Copilot <223556219+Copilot@users.noreply.github.com>

devanathan-vaithiyanathan · 2026-03-05T11:43:06Z

Hi! Could you please apply the AI Summary suggestions?

@kubaflo, I have addressed the AI review summary comment

dotnet-policy-service bot added the community ✨ Community Contribution label Aug 7, 2025

dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Aug 7, 2025

devanathan-vaithiyanathan marked this pull request as ready for review August 12, 2025 13:40

Copilot AI review requested due to automatic review settings August 12, 2025 13:40

devanathan-vaithiyanathan requested a review from a team as a code owner August 12, 2025 13:40

devanathan-vaithiyanathan requested review from jsuarezruiz and rmarinho August 12, 2025 13:40

Copilot AI reviewed Aug 12, 2025

View reviewed changes

romerotg mentioned this pull request Aug 14, 2025

[iOS] TimePicker AM/PM frequently changes when the app is closed and reopened #30837

Open

jsuarezruiz suggested changes Aug 29, 2025

View reviewed changes

jfversluis added this to the .NET 10 SR1 milestone Oct 21, 2025

github-actions bot force-pushed the fix-30837 branch from bb52f5b to e4a60cd Compare October 21, 2025 15:01

PureWeen modified the milestones: .NET 10 SR1, .NET 10.0 SR2 Nov 4, 2025

PureWeen modified the milestones: .NET 10.0 SR2, .NET 10 SR4 Dec 13, 2025

PureWeen modified the milestones: .NET 10.0 SR4, .NET 10 SR5 Jan 21, 2026

devanathan-vaithiyanathan added 9 commits March 3, 2026 22:23

Revert "fix added"

8bfe2c6

This reverts commit 138797f.

fix added

8034127

test case added

fd64c13

modified the changes

26a3504

snapshot added

d3fff31

unwanted changes removed

089c143

Update TimePickerExtensions.cs

7888ef4

Update TimePickerExtensions.cs

f2f3be6

Update TimePickerExtensions.cs

a078de5

kubaflo force-pushed the fix-30837 branch from 021ecd5 to a078de5 Compare March 3, 2026 21:23

kubaflo requested changes Mar 3, 2026

View reviewed changes

PureWeen modified the milestones: .NET 10 SR5, .NET 10 SR6 Mar 3, 2026

ios 26 image added

d8cbff8

Co-Authored-By: Copilot <223556219+Copilot@users.noreply.github.com>

kubaflo added the s/agent-fix-pr-picked AI could not beat the PR fix - PR is the best among all candidates label Mar 4, 2026

kubaflo requested changes Mar 5, 2026

View reviewed changes

AI suggestion updated

267cb6b

Co-Authored-By: Copilot <223556219+Copilot@users.noreply.github.com>

kubaflo added the s/agent-suggestions-implemented Maintainer applies when PR author adopts agent's recommendation label Mar 5, 2026

kubaflo approved these changes Mar 5, 2026

View reviewed changes

kubaflo changed the base branch from main to inflight/current March 5, 2026 12:37

kubaflo merged commit 5f2711d into dotnet:inflight/current Mar 5, 2026
5 of 12 checks passed

	mauiTimePicker.Text = time.ToFormattedString(format ?? string.Empty, formattingCulture);
	mauiTimePicker.Text = time.ToFormattedString(format, formattingCulture);

Conversation

devanathan-vaithiyanathan commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Details

Description of Change

Issues Fixed

Uh oh!

dotnet-policy-service bot commented Aug 7, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes:

Reviewed Changes

Uh oh!

Copilot AI Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Aug 28, 2025

Uh oh!

jsuarezruiz commented Aug 28, 2025

Uh oh!

azure-pipelines bot commented Aug 28, 2025

Uh oh!

azure-pipelines bot commented Aug 28, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

devanathan-vaithiyanathan commented Sep 1, 2025

Uh oh!

jsuarezruiz commented Oct 10, 2025 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines bot commented Oct 10, 2025

Uh oh!

jfversluis commented Oct 21, 2025

Uh oh!

azure-pipelines bot commented Oct 21, 2025

Uh oh!

azure-pipelines bot commented Oct 22, 2025

Uh oh!

azure-pipelines bot commented Oct 22, 2025

Uh oh!

github-actions bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kubaflo left a comment

Choose a reason for hiding this comment

Uh oh!

kubaflo commented Mar 3, 2026

Uh oh!

azure-pipelines bot commented Mar 3, 2026

Uh oh!

devanathan-vaithiyanathan commented Mar 4, 2026

Uh oh!

kubaflo left a comment

Choose a reason for hiding this comment

Uh oh!

devanathan-vaithiyanathan commented Mar 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

devanathan-vaithiyanathan commented Aug 7, 2025 •

edited

Loading

jsuarezruiz commented Oct 10, 2025 •

edited by jfversluis

Loading

github-actions bot commented Mar 3, 2026 •

edited

Loading