[iOS][Shell]Tab becomes blank after specific navigation pattern - fix#29825
Merged
PureWeen merged 13 commits intodotnet:mainfrom Jul 9, 2025
Merged
[iOS][Shell]Tab becomes blank after specific navigation pattern - fix#29825PureWeen merged 13 commits intodotnet:mainfrom
PureWeen merged 13 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where navigating back in the iOS Shell sometimes results in a blank tab by ensuring that the pop navigation request flag is properly set.
- Renames the flag from a private "_popRequested" to an internal "popRequested" to allow external access from related renderers.
- Modifies various navigation methods to use the new flag.
- Introduces back navigation detection in ShellItemRenderer to set the flag appropriately.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRenderer.cs | Replaces _popRequested with an internal popRequested field and updates its usage in navigation-related methods. |
| src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellItemRenderer.cs | Adds detection for back navigation by setting the popRequested flag from the associated ShellSectionRenderer. |
Comments suppressed due to low confidence (2)
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRenderer.cs:73
- [nitpick] Changing the field from a private _popRequested to an internal popRequested may impact encapsulation. Please ensure that this change is intentional and documented to clarify why external access is now required.
internal bool popRequested;
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellItemRenderer.cs:124
- [nitpick] Directly setting the popRequested flag on ShellSectionRenderer in response to back navigation may tightly couple these components. Please verify that this design does not introduce unintended side effects or dependencies.
sectionRenderer.popRequested = true;
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/rebase |
25152b1 to
2bc936c
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
reviewed
Jul 2, 2025
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRenderer.cs
Outdated
Show resolved
Hide resolved
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
2a31f4c to
311df00
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
suggested changes
Jul 8, 2025
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRenderer.cs
Show resolved
Hide resolved
rmarinho
reviewed
Jul 8, 2025
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRenderer.cs
Outdated
Show resolved
Hide resolved
rmarinho
reviewed
Jul 8, 2025
rmarinho
reviewed
Jul 8, 2025
rmarinho
reviewed
Jul 8, 2025
rmarinho
reviewed
Jul 8, 2025
rmarinho
reviewed
Jul 8, 2025
Member
rmarinho
left a comment
There was a problem hiding this comment.
Just small questions and updates
…ctionRenderer.cs Co-authored-by: Rui Marinho <me@ruimarinho.net>
Co-authored-by: Rui Marinho <me@ruimarinho.net>
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issues Fixed
Fixes #29798
Fixes #30280
Screen.Recording.2025-06-05.at.16.02.20.mov
Screen.Recording.2025-06-05.at.16.03.15.mov