[Windows] Fix for ImagePaint Not rendering in View #29205
Closed
HarishwaranVijayakumar wants to merge 3 commits intodotnet:mainfrom
Closed
[Windows] Fix for ImagePaint Not rendering in View #29205HarishwaranVijayakumar wants to merge 3 commits intodotnet:mainfrom
HarishwaranVijayakumar wants to merge 3 commits intodotnet:mainfrom
Conversation
Contributor
|
Hey there @@HarishwaranVijayakumar! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
suggested changes
Apr 28, 2025
| if (paint is ImagePaint imagePaint) | ||
| { | ||
| if (imagePaint.Image is PlatformImage image) | ||
| if (imagePaint.Image is Platform.PlatformImage image) |
Contributor
There was a problem hiding this comment.
Could you include a test?
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/rebase |
Member
|
/triage |
Contributor
|
The changes have already been merged in PR #29138, so this pull request is no longer needed. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause of the issue
Description of Change
Issues Fixed
Fixes #28725
Fixes #29900
Test Case
Tested the behaviour in the follwing platforms
Output