[Testing] Fix for flaky UITests Issue18896 and disable Issue14471 test which fails in CI randomly #28533
Conversation
Contributor
|
Hey there @HarishKumarSF4517! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the flaky UITests in CI by adding an internet connectivity check for Issue18896 and conditionally disabling Issue14471 on Android.
- Updated Issue18896 by adding an isInternetRequired parameter and a VerifyInternetConnectivity() call.
- Disabled the Android test in Issue14471 using a conditional compilation directive.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue14471.cs | Added conditional compilation to disable the test on Android. |
| src/Controls/tests/TestCases.HostApp/Issues/Issue18896.xaml.cs | Updated the Issue attribute to require internet connectivity. |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18896.cs | Inserted a VerifyInternetConnectivity() call in the test method. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/backport to inflight/current |
Contributor
|
Started backporting to inflight/current: https://github.com/dotnet/maui/actions/runs/13972051653 |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
suggested changes
Mar 20, 2025
| @@ -1,4 +1,5 @@ | |||
| using NUnit.Framework; | |||
| #if TEST_FAILS_ON_ANDROID // This test fails randomly, likely because the image source has disappeared sometimes in CI, not able to reproduce locally. For now, we have ignored the test for Android. Issue for re-enabling: https://github.com/dotnet/maui/issues/24243 | |||
Contributor
There was a problem hiding this comment.
Did you run it using the same Api Level? We run tests in two difference API levels and sometimes, something fails from a specific version.
rmarinho
previously approved these changes
Mar 20, 2025
rmarinho
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the test cases in the src/Controls/tests/TestCases.Shared.Tests/Tests/Issues directory. The changes mainly focus on adding internet connectivity checks and conditional compilation for specific platforms.
Test Case Updates:
src/Controls/tests/TestCases.HostApp/Issues/Issue18896.xaml.cs: Added anisInternetRequiredparameter to theIssueattribute for issue 18896 to indicate that internet connectivity is required.src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18896.cs: Added a call toVerifyInternetConnectivity()in theIssue18896Testmethod to ensure internet connectivity is verified before running the test.Platform-Specific Conditional Compilation:
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue14471.cs: Added a conditional compilation directive to exclude the test on Android due to intermittent failures in CI environments. Included a reference to the issue for re-enabling the test. [1] [2]TestCases