[Testing] Enable UITest Issue18193 on MacCatalyst#28210
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
PR Overview
A PR update to enhance the clarity and reliability of UITest Issue18193 on MacCatalyst by renaming button variables and their AutomationId properties as well as refactoring associated test steps.
- Updated Shell tab bar item definitions to properly map pages and types.
- Renamed button variables and updated AutomationId values for consistency.
- Removed the TEST_FAILS_ON_CATALYST directive and updated UITest step references accordingly.
Reviewed Changes
| File | Description |
|---|---|
| src/Controls/tests/TestCases.HostApp/Issues/Issue18193.cs | Updated Shell content creation and button AutomationId names to improve clarity and consistency. |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18193.cs | Adjusted test steps to reference the new AutomationId values and removed obsolete preprocessor directives. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
|
Test failed |
| @@ -17,19 +16,18 @@ public Issue18193(TestDevice testDevice) : base(testDevice) | |||
| [Category(UITestCategories.Shell)] | |||
| public void ShellNavigationShouldWorkInMoreTab() | |||
There was a problem hiding this comment.
Test is failing on Catalyst:
at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2352
at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2369
at UITest.Appium.HelperExtensions.WaitForElement(IApp app, IQuery query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 699
at UITest.Appium.HelperExtensions.WaitForElementTillPageNavigationSettled(IApp app, String elementId, Nullable`1 timeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2079
at Microsoft.Maui.TestCases.Tests.Issues.Issue18193.ShellNavigationShouldWorkInMoreTab() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18193.cs:line 23
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jfversluis
left a comment
There was a problem hiding this comment.
Still a timeout on the one test
at UITest.Appium.HelperExtensions.Wait(Func
1 query, Func2 satisfactory, String timeoutMessage, Nullable1 timeout, Nullable1 retryFrequency) in //src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2460
at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func1 query, String timeoutMessage, Nullable1 timeout, Nullable1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2477 at UITest.Appium.HelperExtensions.WaitForElement(IApp app, IQuery query, String timeoutMessage, Nullable1 timeout, Nullable1 retryFrequency, Nullable1 postTimeout) in //src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 715
at UITest.Appium.HelperExtensions.WaitForElementTillPageNavigationSettled(IApp app, String elementId, Nullable`1 timeout) in //src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2119
at Microsoft.Maui.TestCases.Tests.Issues.Issue18193.ShellNavigationShouldWorkInMoreTab() in //src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18193.cs:line 23
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
Description of Change
This pull request introduces multiple updates to the
Issue18193test cases. The main changes focus on renaming button variables and theirAutomationIdproperties to enhance clarity and consistency, along with minor refactoring aimed at resolving reliability issues on Catalyst platforms within CI environments. Although the specific cause of the ongoing CI failures has not been conclusively identified, these modifications tackle frequent issues that can impact UI test reliability on Catalyst platforms.Test updates:
#if TEST_FAILS_ON_CATALYSTdirective and the related comment from theIssue18193test file.ShellNavigationShouldWorkInMoreTabmethod to use the newAutomationIdvalues for button interactions.Issues Fixed
Fixes #27206