[Windows] Optimize LayoutHandler.Windows.cs (take 3)#26722
Merged
PureWeen merged 13 commits intodotnet:mainfrom Dec 24, 2024
Merged
[Windows] Optimize LayoutHandler.Windows.cs (take 3)#26722PureWeen merged 13 commits intodotnet:mainfrom
LayoutHandler.Windows.cs (take 3)#26722PureWeen merged 13 commits intodotnet:mainfrom
Conversation
Contributor
|
Hey there @MartyIX! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Foda
approved these changes
Dec 20, 2024
jonathanpeppers
approved these changes
Dec 20, 2024
PureWeen
approved these changes
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the same as #26460 but it applies this @jonathanpeppers's suggestion: #26460 (comment). I find it to be a biggish change so I created a new PR to make it easy to compare this one and the previous one #26460.
Description of Change
I've been scratching my head how to improve performance of
LayoutHandlerand it seems that storingChildrenofPlatformViewleads to a significant performance gain in my test scenario (#21787). This PR is a replacement for #26161 that implements @mattleibow's suggestion from the previous PR. Interestingly, the suggestion allows to easily useCachedChildrenin more places and thus improve performance a bit more.Explanation from @Sergio0694:
Speedscope
-> 97% improvement for
IPanelMethods.get_Children.Issues Fixed
Contributes to #21787